Skip to content

tidy: document u64 limit for numeric sort keys#159273

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
kn1g78:tidy-handle-large-numeric-sorts
Jul 16, 2026
Merged

tidy: document u64 limit for numeric sort keys#159273
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
kn1g78:tidy-handle-large-numeric-sorts

Conversation

@kn1g78

@kn1g78 kn1g78 commented Jul 14, 2026 •
edited by workingjubilee
Loading

Copy link
Copy Markdown
Contributor

The tidy-alphabetical checker uses natural sorting for numeric sequences, parsing each sequence as u64.

Document this limit so that numeric sequences in marked lists remain within the supported range.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 14, 2026
@kn1g78
kn1g78 marked this pull request as ready for review July 15, 2026 13:20
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2026
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@clubby789

clubby789 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Why the switch to ASCII?

@kn1g78

kn1g78 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Why the switch to ASCII?

is_numeric also recognizes Unicode numeric characters, while u64::parse only accepts ASCII digits. Using is_ascii_digit keeps the numeric-run detection consistent with the supported numeric syntax and avoids treating Unicode numerals as numeric runs. Supporting Unicode numeric sorting would require separate handling.

@Kivooeo

Kivooeo commented Jul 15, 2026

Copy link
Copy Markdown
Member

which panicked when a marked list contained a number larger than u64::MAX

how often in practice this happens?

@kn1g78

kn1g78 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

which panicked when a marked list contained a number larger than u64::MAX

how often in practice this happens?

this does not currently happen in practice and is unlikely with the existing use cases. This PR is defensive hardening for an undocumented u64 limit in the generic comparator, rather than a fix for an observed failure.

@Kivooeo

Kivooeo commented Jul 15, 2026

Copy link
Copy Markdown
Member

let's just document u64 limit then

@kn1g78 kn1g78 changed the title tidy: handle large numeric sort keys tidy: document u64 limit for numeric sort keys Jul 15, 2026
@kn1g78

kn1g78 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

let's just document u64 limit then

Done. Thank you!

@clubby789

clubby789 commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please update the PR description. In future, please don't use AI to generate PR descriptions
@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d4dff69 has been approved by clubby789

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
@workingjubilee

workingjubilee commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@bors r-

It should have the PR updated for its description first, before approval, because when a rollup is made, that will take the PR description at that moment, not whatever edits are landed. That PR description then becomes a commit message.

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2026
@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@kn1g78

kn1g78 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

done.

@clubby789

clubby789 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d4dff69 has been approved by clubby789

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 16, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159273 - kn1g78:tidy-handle-large-numeric-s…
6474012 
…orts, r=clubby789

tidy: document u64 limit for numeric sort keys

The `tidy-alphabetical` checker uses natural sorting for numeric sequences, parsing each sequence as `u64`.

Document this limit so that numeric sequences in marked lists remain within the supported range.

Tests:
- `cargo test --offline --manifest-path src/tools/tidy/Cargo.toml`
- `x test tidy`
This was referenced Jul 16, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 16, 2026
@bors
Auto merge of #159407 - JonathanBrouwer:rollup-Glp5Zkf, r=JonathanBro…
3d50c25 
…uwer

Rollup of 18 pull requests

Successful merges:

 - #150679 (dirfd file operations (2/4))
 - #158758 (Rename `lazy_type_alias` feature gate to `checked_type_aliases` )
 - #159177 (Explicitly materialize debuginfo tests for all debuggers)
 - #159392 (Update Rust crate rand to v0.9.3 [SECURITY])
 - #159393 (Update Rust crate rkyv to v0.8.16 [SECURITY])
 - #159394 (Update Rust crate tar to v0.4.46 [SECURITY])
 - #159395 (Update Rust crate tracing-subscriber [SECURITY])
 - #159193 (Port compiletest's CLI to clap)
 - #158992 (Shorten types more when only interesting part is lifetimes)
 - #159226 (Track extra_lifetime_params_map per-owner)
 - #159273 (tidy: document u64 limit for numeric sort keys)
 - #159322 (Fix safety doc in intrinsics::simd)
 - #159329 (Fix the stale metrics directory warning)
 - #159357 (Add regression tests for two fixed issues)
 - #159360 (Remove FIXMEs referencing #44232)
 - #159375 (make a couple codegen-llvm tests compatible with 2021 edition)
 - #159381 (emit `(lldb)` prefix to make commands more distinct)
 - #159396 (Update actions/checkout action to v7)
@rust-bors
rust-bors Bot merged commit 0bdf554 into rust-lang:main Jul 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@clubby789 clubby789

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kn1g78 @rustbot @clubby789 @Kivooeo @workingjubilee