tidy: document u64 limit for numeric sort keys#159273
Conversation
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Why the switch to ASCII? |
|
how often in practice this happens? |
this does not currently happen in practice and is unlikely with the existing use cases. This PR is defensive hardening for an undocumented u64 limit in the generic comparator, rather than a fix for an observed failure. |
|
let's just document u64 limit then |
Done. Thank you! |
|
Please update the PR description. In future, please don't use AI to generate PR descriptions |
|
@bors r- It should have the PR updated for its description first, before approval, because when a rollup is made, that will take the PR description at that moment, not whatever edits are landed. That PR description then becomes a commit message. |
|
This pull request was unapproved. |
|
done. |
The
tidy-alphabeticalchecker uses natural sorting for numeric sequences, parsing each sequence asu64.Document this limit so that numeric sequences in marked lists remain within the supported range.
Tests:
cargo test --offline --manifest-path src/tools/tidy/Cargo.tomlx test tidy