Skip to content

Track extra_lifetime_params_map per-owner#159226

Open
oli-obk wants to merge 1 commit into
rust-lang:mainfrom
oli-obk:extra_lifetime_params_map
Open

Track extra_lifetime_params_map per-owner#159226
oli-obk wants to merge 1 commit into
rust-lang:mainfrom
oli-obk:extra_lifetime_params_map

Conversation

@oli-obk

@oli-obk oli-obk commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Part of rust-lang/rust-project-goals#620

An easy one now that #156508 is merged, as there are no more cross-owner dependencies on this table

r? @petrochenkov

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2026
@oli-obk

oli-obk commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 13, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 13, 2026
Track extra_lifetime_params_map per-owner
@rust-bors

rust-bors Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: f6842f2 (f6842f23feea9fd663890d2ddce96c9e55cb3174)
Base parent: 5503df8 (5503df87342a73d0c29126a7e08dc9c1255c46ad)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f6842f2): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [1.1%, 2.8%] 2
Regressions ❌
(secondary)
4.3% [1.1%, 9.8%] 8
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
-7.8% [-7.8%, -7.8%] 1
All ❌✅ (primary) 0.5% [-2.5%, 2.8%] 3

Cycles

Results (primary 2.4%, secondary -4.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.4% [-4.4%, -4.4%] 1
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 487.42s -> 489.163s (0.36%)
Artifact size: 389.91 MiB -> 389.89 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 13, 2026
@oli-obk oli-obk marked this pull request as ready for review July 14, 2026 05:19
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2026
@petrochenkov

petrochenkov commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Is it necessary to move the lifetime functions from LateResolutionVisitor to Resolver?
LateResolutionVisitor should have all the same access to Resolver as Resolver itself, so it should be possible.
These functions are only used during late resolution, so they are implemented on late resolver and live in late.rs.

Upd: alternatively they could be implemented on Resolver and just live in late.rs.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2026
@oli-obk oli-obk force-pushed the extra_lifetime_params_map branch from b1f8ac5 to 5ccf44c Compare July 16, 2026 07:52
@rustbot

rustbot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@oli-obk

oli-obk commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Is it necessary to move the lifetime functions from LateResolutionVisitor to Resolver?

nope, not necessary. I removed that.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants