[WIP] 3 - FPTR_TYPE_DISCR in ABI Version#159075
Draft
jchlanda wants to merge 3 commits into
Draft
Conversation
rustbot
added
A-LLVM
This was referenced Jul 10, 2026
jchlanda
force-pushed
the
jakub/pac_ty_disc_PR_3
branch
2 times, most recently
from
July 14, 2026 07:27
d746518 to
a098946
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jchlanda
force-pushed
the
jakub/pac_ty_disc_PR_3
branch
from
July 14, 2026 08:51
a098946 to
e1b80e7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jchlanda
force-pushed
the
jakub/pac_ty_disc_PR_3
branch
from
July 17, 2026 07:03
e1b80e7 to
7135bea
Compare
This comment has been minimized.
This comment has been minimized.
jchlanda
force-pushed
the
jakub/pac_ty_disc_PR_3
branch
from
July 17, 2026 08:20
7135bea to
66aaf1e
Compare
This patch implements Rust's equivalent of Clang's function pointer type discriminator computation used in pointer authentication. Compatibility with Clang is a primary goal. The discriminator produced for a given external "C" function type must match the value computed by Clang so that function pointers can be exchanged safely between Rust and C code while preserving pointer authentication semantics. The implementation mirrors Clang's behavior in `ASTContext::encodeTypeForFunctionPointerAuth`, ensuring that identical C-compatible function types produce identical discriminators. See: <https://clang.llvm.org/doxygen/ASTContext_8cpp.html#abb1375e068e807917527842d05cadea3>.
This patch introduces the following: * Extends `FnAbi` (`callconv`) with a `ptrauth_type_discriminator` field. This field is only used when emitting pointer authentication call bundles. It is stored in `FnAbi` because the call site is not guaranteed to have access to an `Instance`, so the discriminator cannot always be computed on demand. * Adds support for `llvm.ptrauth.resign`. This intrinsic will be used when support for semantic transmute is added. * Performs a minor API redesign as groundwork for allowing call sites to modify schemas in place.
Also remove error messages/tests that used to guarded it.
jchlanda
force-pushed
the
jakub/pac_ty_disc_PR_3
branch
from
July 17, 2026 09:47
66aaf1e to
951b670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch extends ABI version to contain FPTR_TYPE_DISCR. It also removes error messages/tests that used to guarded (previously unsupported) function pointer type discrimination.
This is part 3 of a sequence of 8 PRs, that together aim to bring function pointer type discrimination support:
Useful links:
pauthtestintroduction: Introduce aarch64-unknown-linux-pauthtest target #155722