Skip to content

Update to LLVM 23#158734

Draft
nikic wants to merge 15 commits into
rust-lang:mainfrom
nikic:llvm23
Draft

Update to LLVM 23#158734
nikic wants to merge 15 commits into
rust-lang:mainfrom
nikic:llvm23

Conversation

@nikic

@nikic nikic commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2026
@nikic

nikic commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 3, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 3, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
b003a3f 
Update to LLVM 23
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

💔 Test for b003a3f failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 13, 2026
@nikic

nikic commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 13, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
0259978 
Update to LLVM 23
@rust-bors

rust-bors Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 0259978 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikic

nikic commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 14, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
4973bfc 
Update to LLVM 23
@rust-bors

rust-bors Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 4973bfc failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikic

nikic commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Jul 16, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
2c1f844 
Update to LLVM 23
@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 2c1f844 (2c1f8447a3951d07e7476a97da686dcd14a3e3cd)
Base parent: d62fb1c (d62fb1c8a007f6967376a52da8315ae51b64a70c)

@rust-timer

This comment has been minimized.

Sign in to view
@nikic

nikic commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=dist-x86_64-apple,x86_64-mingw-1,x86_64-mingw-2,dist-i686-mingw,dist-x86_64-mingw,dist-aarch64-llvm-mingw,dist-x86_64-llvm-mingw

rust-bors Bot pushed a commit that referenced this pull request Jul 16, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
de5468d 
Update to LLVM 23


try-job: dist-x86_64-apple
try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
try-job: dist-i686-mingw
try-job: dist-x86_64-mingw
try-job: dist-aarch64-llvm-mingw
try-job: dist-x86_64-llvm-mingw
@rust-bors

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (2c1f844): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.4% [0.1%, 0.7%] 17
Regressions ❌
(secondary)		 5.8% [0.2%, 13.7%] 33
Improvements ✅
(primary)		 -3.2% [-15.7%, -0.2%] 158
Improvements ✅
(secondary)		 -2.2% [-11.7%, -0.2%] 202
All ❌✅ (primary) -2.8% [-15.7%, 0.7%] 175

Max RSS (memory usage)

Results (primary 1.0%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 4.8% [2.1%, 8.1%] 5
Regressions ❌
(secondary)		 3.4% [2.7%, 4.1%] 4
Improvements ✅
(primary)		 -1.4% [-2.1%, -0.5%] 8
Improvements ✅
(secondary)		 -3.2% [-9.4%, -0.8%] 42
All ❌✅ (primary) 1.0% [-2.1%, 8.1%] 13

Cycles

Results (primary -5.3%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 7.9% [2.9%, 14.9%] 11
Improvements ✅
(primary)		 -5.3% [-11.8%, -1.4%] 58
Improvements ✅
(secondary)		 -4.7% [-8.8%, -2.2%] 44
All ❌✅ (primary) -5.3% [-11.8%, -1.4%] 58

Binary size

Results (primary -0.2%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.1%] 12
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 5
Improvements ✅
(primary)		 -0.3% [-1.3%, -0.0%] 35
Improvements ✅
(secondary)		 -0.9% [-1.3%, -0.0%] 59
All ❌✅ (primary) -0.2% [-1.3%, 0.1%] 47

Bootstrap: 489.85s -> 459.406s (-6.21%)
Artifact size: 389.48 MiB -> 397.37 MiB (2.03%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 16, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

💔 Test for de5468d failed: CI. Failed jobs:

@nikic

nikic commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=x86_64-msvc-1,x86_64-msvc-2,i686-msvc-1,i686-msvc-2,aarch64-msvc-1,aarch64-msvc-2,x86_64-msvc-ext1,x86_64-msvc-ext2,x86_64-msvc-ext3,dist-x86_64-msvc,dist-i686-msvc,dist-aarch64-msvc,dist-x86_64-msvc-alt

@rust-bors

rust-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Invalid command: Try jobs must not have more than 10 jobs. Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

@nikic

nikic commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=x86_64-msvc-1,x86_64-msvc-2,i686-msvc-1,i686-msvc-2,aarch64-msvc-1,aarch64-msvc-2,x86_64-msvc-ext1,x86_64-msvc-ext2,x86_64-msvc-ext3

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
4746cd1 
Update to LLVM 23


try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: aarch64-msvc-1
try-job: aarch64-msvc-2
try-job: x86_64-msvc-ext1
try-job: x86_64-msvc-ext2
try-job: x86_64-msvc-ext3
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol

Kobzol commented Jul 17, 2026

Copy link
Copy Markdown
Member

You can also say jobs=*msvc* and it will run every job with msvc in its name (as long as there is not too many of those 🤔 ).

@rust-bors

rust-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 4746cd1 failed: CI. Failed jobs:

nikic and others added 3 commits July 17, 2026 15:08
@nikic
add patch
98313d8
@tgross35 @nikic
x86_64-win: Return f128 on the stack, matching LLVM
c9244e7 
We can start matching the codegen introduced by LLVM at [1]. This alone
isn't enough to make f128 functional on the platform because libcalls
use the LLVM ABI.

Current behavior originally introduced in RUST-128388.

[1]: llvm/llvm-project@aa47e59
@folkertdev @nikic
fix f128 libcall abi in the cranelift backend
44eee4b
@nikic

nikic commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=x86_64-msvc-2,i686-msvc-1,i686-msvc-2,dist-x86_64-msvc,dist-i686-msvc,dist-aarch64-msvc,dist-x86_64-msvc-alt,dist-i686-linux,dist-x86_64-linux-alt,dist-x86_64-linux

@rust-bors

rust-bors Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⌛ Trying commit 44eee4b with merge 16ed2d6…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/29583368448

rust-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
@bors
Auto merge of #158734 - nikic:llvm23, r=<try>
16ed2d6 
Update to LLVM 23


try-job: x86_64-msvc-2
try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: dist-x86_64-msvc
try-job: dist-i686-msvc
try-job: dist-aarch64-msvc
try-job: dist-x86_64-msvc-alt
try-job: dist-i686-linux
try-job: dist-x86_64-linux-alt
try-job: dist-x86_64-linux
@rust-bors

rust-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

💥 Test timed out after 21600s

@rust-bors

rust-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #159444) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc F-autodiff `#![feature(autodiff)]` perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nikic @rust-timer @rust-log-analyzer @Kobzol @rustbot @tgross35 @folkertdev