Move rustdoc run-make tests into new tests/run-make/rustdoc/#157860
Merged
rust-bors[bot] merged 1 commit intoJul 18, 2026
Conversation
Collaborator
|
|
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
notriddle
approved these changes
Jul 16, 2026
Contributor
|
this looks fine, but needs rebased |
Furthermore, populate `tests/run-make/rustdoc/doctest/` with doctest run-make tests and `tests/run-make/rustdoc/scrape-example/` with scrape example run-make tests.
fmease
force-pushed
the
mkdir-tests-run-make-rustdoc
branch
from
July 18, 2026 13:21
ecf2b75 to
7cc650f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=notriddle rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 18, 2026
…uwer Rollup of 8 pull requests Successful merges: - #159425 (Windows: add context when opening NUL for child stdio fails) - #159467 (Add explicit `Iterator::count` impl for `str::EncodeUtf16`) - #157860 (Move rustdoc run-make tests into new `tests/run-make/rustdoc/`) - #158545 (Move `std::io::read_to_string` to `alloc::io`) - #159328 (tests/assembly-llvm: pin frame pointer in issue-141649 aarch64 test) - #159459 (Detect when trait bound requires closure to return itself) - #159470 (Fix string indexing in diagnostic format strings) - #159500 (Move compiletest CLI parsing to `cli.rs`)
rust-timer
added a commit
that referenced
this pull request
Jul 18, 2026
Rollup merge of #157860 - fmease:mkdir-tests-run-make-rustdoc, r=notriddle Move rustdoc run-make tests into new `tests/run-make/rustdoc/` Furthermore, populate `tests/run-make/rustdoc/doctest/` with doctest run-make tests and `tests/run-make/rustdoc/scrape-example/` with scrape-example run-make tests. For context we currently have 11 doctest run-make tests + 8 scrape-example run-make tests + 24 other rustdoc run-make tests = 43 rustdoc run-make tests in total. **Motivation**: Sorta obvious but 1. I want to be able to just call e.g., `./x t tests/run-make/rustdoc/doctest tests/rustdoc-ui/doctest` when working on doctest internals to quickly see if anything broke instead of having to execute all run-make tests "every time I make a small change" 2. having them in one official place makes it a lot easier to spot which areas might need more coverage, to take inspiration from existing rustdoc run-make tests, to find existing test files that one can extend instead of creating a whole new run-make test, etc. r? rustdoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Furthermore, populate
tests/run-make/rustdoc/doctest/with doctest run-make tests andtests/run-make/rustdoc/scrape-example/with scrape-example run-make tests.For context we currently have 11 doctest run-make tests + 8 scrape-example run-make tests + 24 other rustdoc run-make tests = 43 rustdoc run-make tests in total.
Motivation: Sorta obvious but
./x t tests/run-make/rustdoc/doctest tests/rustdoc-ui/doctestwhen working on doctest internals to quickly see if anything broke instead of having to execute all run-make tests "every time I make a small change"r? rustdoc