ci: Enable autodiff tests on x86_64 linux#157776
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
a5999ca to
7da709a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
No problem found |
851ebe4 to
33566ea
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
27ed09b to
57ed38d
Compare
This comment has been minimized.
This comment has been minimized.
57ed38d to
69603c6
Compare
|
Warning If you are changing how CI LLVM is built or linked, make sure to bump cc @jieyouxu |
|
@bors try jobs=x86_64-gnu-autodiff Rerunning to test potential cache effects. |
This comment has been minimized.
This comment has been minimized.
ci: Enable autodiff tests on x86_64 linux try-job: x86_64-gnu-autodiff
|
Rebuilding a second time, since I'm not sure if artifacts are shared between PR Ci and try runs. But so far, even just building LLVM+rustc+std+enzyme takes 95 minutes, 10 minutes more than miri, the next slowest job. Total time will always be a bit more than that, and autodiff will always have less users than something general like Miri, so that's hard to defend. If the try results come back unchanged, can you move it to auto and mark it as allowed to fail? I don't think it needs to be blocking yet. |
This comment has been minimized.
This comment has been minimized.
ci: Enable autodiff tests on x86_64 linux try-job: x86_64-gnu-autodiff
There is now only a single "module asm", not one before each line.
The assume here is not really relevant to the purpose of the test, and it's position changed in LLVM 23.
Codegen changed in: llvm/llvm-project@66c1b6f
This doesn't optimize as desired since: llvm/llvm-project@21f439f
These now have additional !guid metadata.
We probably want to change this to align with Linux, but for now keep the old behavior.
It's a dependency of LLVM now.
|
submodule updates are meant to be trivial so those not breaking us doesn't mean much. There's an open update to llvm23, can you test if that breaks something? But I generally wouldn't want to block this on an MCP and (for now) I'd rather like us to chase optional CI failures since that's up to us, rather than pushing bugfixes onto other people, at least for now. |
* Enable autodiff tests on x86_64 linux * move autodiff job def * remove redundant ./x build
We can start matching the codegen introduced by LLVM at [1]. This alone isn't enough to make f128 functional on the platform because libcalls use the LLVM ABI. Current behavior originally introduced in RUST-128388. [1]: llvm/llvm-project@aa47e59
928c0cf to
74c230e
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Some changes occurred in src/tools/enzyme cc @ZuseZ4 This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. Some changes occurred in coverage tests. cc @Zalathar
cc @bjorn3 |
|
|
@bors try jobs=optional-x86_64-gnu-autodiff |
This comment has been minimized.
This comment has been minimized.
ci: Enable autodiff tests on x86_64 linux try-job: optional-x86_64-gnu-autodiff
|
☔ The latest upstream changes (presumably #159444) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
View all comments
Enable autodiff tests on x86_64 linux
hmm.....pr job x stage 1 takes 100 - 110min, which is the slowest in the pr jobs.
If we are not happy to wait more than 100min for the pr jobs, maybe we should move this to auto jobs and test them on stage 2
r? @ZuseZ4