Skip to content

remove some SSE/SSE2 intrinsics that are no longer used by stdarch - #3747

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:sse-cleanup
Aug 7, 2024
Merged

remove some SSE/SSE2 intrinsics that are no longer used by stdarch#3747
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:sse-cleanup

Conversation

@RalfJung

Copy link
Copy Markdown
Member

Fixes #3691

@RalfJung

Copy link
Copy Markdown
Member Author

Blocked on rust-lang/stdarch#1584 propagating to the rustc repo.

@RalfJung RalfJung added the S-blocked Status: blocked on something happening somewhere else label Jul 13, 2024
@TDecking

Copy link
Copy Markdown
Contributor

The stdarch patch will also ensure that the "sqrt.ps.256" case in https://github.com/rust-lang/miri/blob/master/src/shims/x86/avx.rs#L78 will never be reached. This case is still present here.

@RalfJung

Copy link
Copy Markdown
Member Author

Yeah, but sqrt is implemented together with two other functions there so there's not really any code saved by removing that... 🤷

The same goes for sse.sqrt.ss, sse.sqrt.ps.

@RalfJung

Copy link
Copy Markdown
Member Author

Hm I guess this removes all uses of FloatUnaryOp::Sqrt. So maybe it's worth it after all.

@TDecking

TDecking commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

@RalfJung rust-lang/rust#128466 got merged. This PR is no longer blocked.

@RalfJung

RalfJung commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

Ah, good point, thanks! :)

@bors r+

@bors

bors commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 8bf6dae has been approved by RalfJung

It is now in the queue for this repository.

bors added a commit that referenced this pull request Aug 7, 2024
remove some SSE/SSE2 intrinsics that are no longer used by stdarch

Fixes #3691
@bors

bors commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8bf6dae with merge 0537b14...

@bors

bors commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-actions

@RalfJung

RalfJung commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

Ah, maybe we need the rustup to land first.

@RalfJung

RalfJung commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

Hm, no... we had a rustup yesterday, so rust-lang/rust#128466 should have been picked up.

@RalfJung

RalfJung commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

D'oh, this is from a Miri test directly importing the intrinsic.^^

@RalfJung

RalfJung commented Aug 7, 2024

Copy link
Copy Markdown
Member Author

@bors r+

@bors

bors commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 3e79bb4 has been approved by RalfJung

It is now in the queue for this repository.

@RalfJung RalfJung removed the S-blocked Status: blocked on something happening somewhere else label Aug 7, 2024
@bors

bors commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 3e79bb4 with merge 2ae377f...

@bors

bors commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2ae377f to master...

@bors
bors merged commit 2ae377f into rust-lang:master Aug 7, 2024
@RalfJung
RalfJung deleted the sse-cleanup branch August 7, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead Intel intrinsics

3 participants