build: Rename thumb_1 to thumb_1_only and add a disabled assertion - #1319
Merged
Conversation
tgross35
force-pushed
the
thumb-config
branch
4 times, most recently
from
September 8, 2026 05:47
59e67a3 to
01fba10
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
enabled auto-merge (rebase)
September 8, 2026 05:47
tgross35
force-pushed
the
thumb-config
branch
from
September 8, 2026 05:48
01fba10 to
5f47733
Compare
This is a rather old config, added in c924aed ("Fix Armv8-M Baseline compilation"). `thumb_1` is somewhat misleading, since targets with `thumb2` also support basic `thumb` instructions. Rename it to be more clear about what this is actually checking. The config is not currently used but may be in the future.
We still match on target name because we can't always rely on config from the unstable `arm_target_feature`. However, we can still assert that things match up when running in the compiler-builtins CI. This is disabled for now because it fails on three thumb targets: * thumbv4t-none-eabi * thumbv5te-none-eabi * thumbv6-none-eabi This will be resolved in a future commit. Checking for the verbose build is a good indicator that we are in our CI, rather than any other that might set the `CI` env.
tgross35
force-pushed
the
thumb-config
branch
from
September 8, 2026 05:48
5f47733 to
ea6291f
Compare
tgross35
disabled auto-merge
September 8, 2026 05:59
tgross35
enabled auto-merge (rebase)
September 8, 2026 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for details