Skip to content

rustdoc: rename the doc parts metadata params#17234

Merged
weihanglo merged 1 commit into
rust-lang:masterfrom
notriddle:changed-merge-attrs
Jul 18, 2026
Merged

rustdoc: rename the doc parts metadata params#17234
weihanglo merged 1 commit into
rust-lang:masterfrom
notriddle:changed-merge-attrs

Conversation

@notriddle

Copy link
Copy Markdown
Contributor

Follow up rust-lang/rust#159415

The rustdoc CLI interface was slightly simplified for CCI, and should be usable even if more data is moved through this metadata system.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2026
@rustbot

rustbot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo
  • Random selection from epage, weihanglo

@notriddle
notriddle force-pushed the changed-merge-attrs branch from 13bdeea to f1e1ac1 Compare July 17, 2026 22:42
@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-rebuild-detection Area: rebuild detection and fingerprinting Command-doc labels Jul 17, 2026
@rustbot

rustbot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@weihanglo weihanglo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Excited to see the direction (rust-lang/rust#159415 (comment)) we are heading toward!

View changes since this review

@weihanglo

Copy link
Copy Markdown
Member

Oops. I guess we need to wait till tomorrow

@weihanglo
weihanglo enabled auto-merge July 18, 2026 16:52
@weihanglo
weihanglo added this pull request to the merge queue Jul 18, 2026
Merged via the queue into rust-lang:master with commit 57f7298 Jul 18, 2026
45 of 58 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2026
@notriddle
notriddle deleted the changed-merge-attrs branch July 18, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build-execution Area: anything dealing with executing the compiler A-rebuild-detection Area: rebuild detection and fingerprinting Command-doc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants