Clarify std::env::args encoding requirements - #4800
Open
coyaSONG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4796.
Clarifies that
std::env::argspanics when an operating-system argument cannot be represented as a RustString. The text now calls out the platform-specific cases: invalid UTF-8 on Unix and invalid UTF-16 on Windows.This avoids implying that Unicode itself is invalid while remaining accurate across platforms.
Tested with:
npx --yes dprint check src/ch12-01-accepting-command-line-arguments.mdmdbook buildusing the CI version, 0.5.1bash ci/validate.shcargo run --bin lfp srcAI-assisted: Codex. I verified the wording against the official
std::env::argsandOsStringdocumentation and reviewed the generated HTML.