bank-templates: point at the current commit hash for v2.0.0 - #14175
Closed
TheSpryt wants to merge 1 commit into
Closed
bank-templates: point at the current commit hash for v2.0.0#14175TheSpryt wants to merge 1 commit into
TheSpryt wants to merge 1 commit into
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Member
|
do not rewrite commit history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points bank-templates at commit 534252c96f0ab7cb4c2a066d3bef56a12296a5ed. Same v2.0.0 code as the commit merged in #14173, no plugin changes.
#14173 was merged pointing at ec2388a3715896648b05a367d3f2f1e353f297de. I rewrote the repository's history shortly afterwards (normalising commit authorship), which changed every commit hash, so that hash is no longer reachable from any branch. It still resolves today because GitHub has not collected the object yet, but it will stop resolving eventually and the build would then fail to clone it.
534252c is the same tree on the current default branch. Verified identical:
git diff ec2388a 534252c -- src/ runelite-plugin.propertiesis empty.Sorry for the extra PR - I should have repointed before the rewrite rather than after.