ImpFinder#14142
Conversation
|
New plugin |
|
The build.yml check is failing only due to a pre-existing, unrelated impling-finder manifest entry ("build" must be set in its own runelite-plugin.properties) that gets swept into every full-hub rebuild since the packager can't download a previous manifest to diff against on this PR. impfinder itself builds successfully. see the log: impfinder: done in 26284ms [2/2], BUILD SUCCESSFUL in 24s, valid jar built from commit 2d9e0e0. Flagging in case a maintainer wants to take a look despite the red X. |
|
Why are you changing an existing plugin and also adding a new plugin? |
Additionally, this is just not true. Your LLM is hallucinating. You need to set a |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
ImpFinder is intentionally a separate, independent plugin, not an update to the existing impling-finder listing. I was a collaborator on Hablapatabla's original ImplingFinder and submitted a couple of PRs to it, but he's gone unresponsive to those for several weeks now. Rather than keep waiting, I built ImpFinder from scratch under my own name, with my own Supabase backend (his uses Oracle Cloud, which has real reliability limits) and my own issue tracker. It's meant to stand on its own, not replace or modify his existing listing. a stale local change had repointed its repository= line. Reverted, so this PR now only touches plugins/impfinde |
|
Are you able to talk as a human and not through an LLM? Your license does not attribute where the bulk of your code comes from. We would prefer you submit a plugin takeover if the original plugin is no longer maintained. |
|
Sure, I can change the license to show where a bulk of the code came from. I tried a take over a few months ago. I ended up closing that because Habla responded back to me on discord and made me a contributor. He told me to do fixes and then merge the old database to the new one and run them simultaneously to see how they run together. I sent both those out for his review on 6/18/2026 and he never responded but I have seen him online since then. PR #35: Hablapatabla/ImplingFinder#35 So, if you would like me to do another plugin take over request I would like consideration of I am already a contributor and have not heard anything from Habla since 6/18/2026 to be taken into account and expedite the take over rather than start the whole process over again. |
ImpFinder — crowdsources impling locations across all 12 real OSRS impling types via a Supabase backend