fix: irb_require matches similar names - #1253
Merged
tompng merged 1 commit intoSep 12, 2026
Merged
Conversation
tompng
approved these changes
Sep 12, 2026
Member
|
Looks good. Thank you 👍 In this repository and in most repositories in ruby org, you don't need to create a short-lived issue just to pair with a bug fix PR. Of course a standalone bug report issue or an issue meant for bigger discussion is always welcome 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1252
Previously, requiring foo could be skipped if foo2.rb was already loaded. The filename matching now requires an exact match, and a regression test covers this case.