You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that I wasn't able to successfully re-run yarn because I have a different system version of yarn from what others are using. (Once #788 is merged then we'll be able to consistently run yarn without worrying about the system version.)
Before releasing, we'll want to update the shiny version referred to in DESCRIPTION and in package.json.
Just to add a bit of detail: each message sent (via the R functions accordion_panel_insert() and accordion_panel_open() ends up putting a message on the JS side in the actionQueue, where they are handled as serially -- by awaiting each message handler.
This PR makes receiveMessage async, and within it, it awaits each call to renderContent. These changes (along with the PR in Shiny) ensure that the messages are handled in order, without any interleaved processing of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #872. It should be used with rstudio/shiny#3930.
With this PR, this what the test app from #872 looks like when it starts: