feat: Add toolbar_download_button()#1298

Open

elnelson575 wants to merge 49 commits into

mainfrom

feat/toolbar-download-button

Commits on May 29, 2026

Add design spec for toolbar_download_button()

E Nelson
and
claude
committed
feat: Add toolbar_download_button() R functions

E Nelson
and
claude
committed
feat: Add TypeScript binding for toolbar_download_button

E Nelson
and
claude
committed
feat: Add SCSS styles for toolbar_download_button

E Nelson
and
claude
committed
test: Add tests for toolbar_download_button

E Nelson
and
claude
committed
`air format` (GitHub Actions)

elnelson575
authored and
E Nelson
committed
`devtools::document()` (GitHub Actions)

elnelson575
authored and
E Nelson
committed
Resave distributed files (GitHub Action)

elnelson575
authored and
E Nelson
committed
Resave data (GitHub Action)

elnelson575
authored and
E Nelson
committed
Address PR review feedback

E Nelson
and
claude
committed
Use custom message handler instead of InputBinding for download button

E Nelson
and
claude
committed
feat: expand toolbarDownloadButton message handler to support label, icon, showLabel

E Nelson
and
claude
committed
fix: correct imports, add null guards, use hasDefinedProperty in toolbarDownloadButton
E Nelson
committed
fix: gate toolbar download button hover/focus behind btn-default to respect variant classes
E Nelson
committed
test: add failing tests for toolbar_download_button() enabled param

E Nelson
and
claude
committed
feat: wrap shiny::downloadButton() and replace disabled with tristate enabled param

E Nelson
and
claude
committed
fix: use dev shiny downloadButton(enabled=) directly, remove post-processing workaround
E Nelson
committed
feat: expand update_toolbar_download_button() with label, icon, show_label params
E Nelson
committed
chore: rebuild components and regenerate docs
E Nelson
committed
test: update toolbar_download_button() snapshots for enabled param
E Nelson
committed
docs: rewrite download-button demo for three enabled modes
E Nelson
committed
fix: align with Shiny PR #4371 — rename data-ignore-update to data-shiny-disable-auto-enable

E Nelson
and
claude
committed
feat: warn on invalid enabled values in toolbar_download_button()

E Nelson
and
claude
committed
Updated to add commented gate + tests
E Nelson
committed
chore: remove download-button design doc and autoenable demo
E Nelson
committed
feat: add toolbar_download_button with class support and fix hover styles
E Nelson
committed
refactor: address PR review comments on toolbar_download_button
E Nelson
committed
refactor: replace toolbar SCSS mixin with explicit shared selector block
E Nelson
committed
fix: align toolbar_download_button border class with toolbar_input_button
E Nelson
committed
chore: commit compiled JS dist for toolbarDownloadButton.ts changes
E Nelson
committed
docs: explain why action-label/action-icon wrappers are built manually
E Nelson
committed
docs: clarify LibSass comment and note download-button color overrides location
E Nelson
committed
refactor: simplify shared toolbar button styles to plain combined selector
E Nelson
committed
refactor: consolidate shared toolbar button layout and interaction styles
E Nelson
committed
fix: restore text-decoration suppression for all download button variants
E Nelson
committed
test: toolbar test review — fix false-green, add 5 uncovered paths, tighten class check
E Nelson
committed
docs: use @inheritParams for toolbar_download_button, expand example with shinyApp + downloadHandler
E Nelson
committed
fix: guard label_text check with !is.null(label) in update functions; align comments
E Nelson
committed
docs: remove renderUI note from enabled param — general Shiny behavior, not specific here
E Nelson
committed
chore: restore height comment in toolbar button block
E Nelson
committed
chore: expand hover/active rules, clarify color comment in toolbar button block
E Nelson
committed
chore: recompile CSS after rebase on main
E Nelson
committed
test: clarify show_label test comment re: icon default
E Nelson
committed
fix: update_toolbar_download_button() and test cleanup
E Nelson
committed
docs: inheritParams for update_toolbar_download_button
E Nelson
committed
`air format` (GitHub Actions)
elnelson575
committed
`devtools::document()` (GitHub Actions)
elnelson575
committed
`yarn build` (GitHub Actions)
elnelson575
committed
Resave data (GitHub Action)
elnelson575
committed