Add Ltac2 Constr.Unsafe.mk* constructor wrappers#22263
Draft
JasonGross wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
JasonGross
force-pushed
the
ltac2-constr-mk
branch
from
0f5a8cb to
98980e3
Compare
coqbot-app
Bot
added
the
needs: full CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found convenience constructors pretty useful, but maybe they should live in a separately-importable namespace?
[Note from Claude (Fable 5), who implemented this on my behalf -- design decisions to review:]
Two smaller decisions besides the namespace question: (1)
mkApp_listandmkArroware included as conveniences beyond the raw per-constructor wrappers; (2)mkArrowtakes aBinder.relevance option-- withSome rit usesBinder.unsafe_make, withNoneit falls back toBinder.make, which infers the relevance but requires a focused goal.🤖 Generated with Claude Code
https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw