-package delay resolving until -I have been processed#22259
Open
SkySkimmer wants to merge 1 commit into
Open
Conversation
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
package-delay-resolv
branch
from
8126c7e to
4f628fa
Compare
coqbot-app
Bot
removed
the
request: full CI
Contributor
Author
Contributor
Author
|
BTW we may end up needing to add -I support for coqdoc & co |
Comment on lines
-395
to
-396
| ~vo_path:(List.rev opts.vo_path) | ||
| ~ml_path:(List.rev opts.ml_path) |
Contributor
There was a problem hiding this comment.
Seems like these reversals got lost: doesn't the order matter?
Contributor
Author
There was a problem hiding this comment.
it probably does not matter
Contributor
There was a problem hiding this comment.
I think it does for vo_path, unless we systematically fail in case of ambiguity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See test for why/when this is needed.