Fix #21816: Error: Ill-formed constant (wrong canonical name).#22243
Open
ppedrot wants to merge 1 commit into
Open
Fix #21816: Error: Ill-formed constant (wrong canonical name).#22243ppedrot wants to merge 1 commit into
ppedrot wants to merge 1 commit into
Conversation
…me). We tweak Mod_subst.add_delta_resolver by trying to preserve equivalence information instead of replacing it with inlining information. Kernel-wise this cannot be worse than the previous version, as the inlined body should be convertible to the equivalent name. Meanwhile, it fixes rocq-prover#21816 which stemmed from the upper layers that relied on the composition of substitutions to compute libobjects in one go. This fix was suggested by Claude Opus. I am not 100% convinced there is not an other design issue somewhere high up in Declaremods that could have been solved differently, especially without touching the kernel at all. But as explained above, this change should not hurt kernel consistenty. (Famous last words.)
ppedrot
added
kind: fix
coqbot-app
Bot
removed
the
request: full CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tweak Mod_subst.add_delta_resolver by trying to preserve equivalence information instead of replacing it with inlining information. Kernel-wise this cannot be worse than the previous version, as the inlined body should be convertible to the equivalent name. Meanwhile, it fixes #21816 which stemmed from the upper layers that relied on the composition of substitutions to compute libobjects in one go.
This fix was suggested by Claude Opus. I am not 100% convinced there is not an other design issue somewhere high up in Declaremods that could have been solved differently, especially without touching the kernel at all. But as explained above, this change should not hurt kernel consistenty. (Famous last words.)