Skip to content

Add Ltac2 Char.is_space, String.split_on_char and String.trim#22239

Open
JasonGross wants to merge 1 commit into
rocq-prover:masterfrom
JasonGross:ltac2-string-split-trim
Open

Add Ltac2 Char.is_space, String.split_on_char and String.trim#22239
JasonGross wants to merge 1 commit into
rocq-prover:masterfrom
JasonGross:ltac2-string-split-trim

Conversation

@JasonGross

Copy link
Copy Markdown
Member

[Written by Claude (Fable 5) via Claude Code, on behalf of @JasonGross; extracted from a larger Ltac2 utility library. One of a series of small independent Ltac2 stdlib additions.]

Adds whitespace handling to Ltac2.Char/Ltac2.String: Char.is_space (space, tab, newline, carriage return, form feed — the same set as OCaml's String.trim), String.split_on_char with OCaml semantics (result never empty, empty segments preserved, String.concat (String.make 1 sep) (split_on_char sep s) = s), and String.trim.

Design note: the isolated decisions are the whitespace character set and the empty-segment behavior of split_on_char.

🤖 Generated with Claude Code

https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw

@coqbot-app coqbot-app Bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 8, 2026
@JasonGross JasonGross force-pushed the ltac2-string-split-trim branch from 57166f4 to f855903 Compare July 8, 2026 18:17
@JasonGross JasonGross marked this pull request as ready for review July 9, 2026 02:08
@JasonGross JasonGross requested a review from a team as a code owner July 9, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant