fix(completer): guard against index panic when job deleted during completion#1308
Merged
brandur merged 3 commits intoJul 16, 2026
Merged
Conversation
brandur
reviewed
Jul 16, 2026
| // The driver intentionally returns 0 rows when a job is deleted while the | ||
| // completer is finalizing it (see UnknownJobIgnored shared driver test). | ||
| // Guard against an index-out-of-range panic in that case. | ||
| if len(jobs) == 0 { |
Contributor
There was a problem hiding this comment.
Just as a minor stylistic nit, can you change these to if len(jobs) < 1?
Contributor
Author
|
Done — changed to |
Contributor
|
Thanks! Actually, two more small things:
|
brandur
approved these changes
Jul 16, 2026
brandur
added a commit
that referenced
this pull request
Jul 17, 2026
…#1312) This one's a follow up to #1308 which modifies the completers to handle a rare condition where no rows are returned from `JobSetStateIfRunningMany`. Codex caught it while I was looking at the other PR. Here, also modify `JobSetStateIfRunningMany` in the SQLite driver so that if a job is missing from query return, in omits the element completely instead of adding a `nil` element in the return slice, bringing its behavior in line with Postgres. We add a check in the driver test suite to verify the consistent behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
InlineCompleter.JobSetStateIfRunning(~line 96) andAsyncCompleter.JobSetStateIfRunning(~line 205) indexjobs[0]unconditionally after callingpilot.JobSetStateIfRunningMany.The river driver intentionally returns 0 rows when a job is deleted while the completer is finalizing it — this is the
UnknownJobIgnoredcontract documented in the shared driver tests. When that happens, both completers panic with an index-out-of-range error instead of handling the case gracefully.Fix
Add a
len(jobs) == 0guard before thejobs[0]access in bothInlineCompleterandAsyncCompleter. When the driver signals that the job no longer exists (by returning an empty slice), the completer returnsniland silently skips emitting a subscribe event — matching the driver's documented intent.Two new unit tests (
TestInlineJobCompleter_CompleteDeletedJobandTestAsyncJobCompleter_CompleteDeletedJob) exercise this path using the existingpartialExecutorMockinfrastructure, confirming no panic occurs.Closes #1303