refactor(storage): use new higher rank lifetime assumption to avoid unnecessary clone#23490
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
wenym1
marked this pull request as ready for review
October 16, 2025 09:58
wenym1
changed the base branch from
yiming/bump-toolchain-20251010
to
graphite-base/23490
October 16, 2025 10:16
wenym1
force-pushed
the
graphite-base/23490
branch
from
October 16, 2025 10:19
a08f8ef to
64c1eb3
Compare
wenym1
force-pushed
the
yiming/storage-pass-higher-ranked-lifetime
branch
from
October 16, 2025 10:19
3693fe9 to
5d0b2a0
Compare
wenym1
changed the base branch from
graphite-base/23490
to
yiming/bump-toolchain-20251010
October 16, 2025 10:19
buildkite-limited-access
Bot
requested review from
xiangjinwu
and removed request for
a team
October 16, 2025 16:57
|
Looks like this PR extends new SQL syntax or updates existing ones. Make sure that:
|
wenym1
force-pushed
the
yiming/storage-pass-higher-ranked-lifetime
branch
from
October 17, 2025 05:36
5d0b2a0 to
aaf3dd0
Compare
wenym1
force-pushed
the
yiming/storage-pass-higher-ranked-lifetime
branch
from
October 20, 2025 03:38
cc04230 to
c6bac47
Compare
BugenZhao
approved these changes
Oct 21, 2025
|
|
||
| echo "--- Build documentation" | ||
| RUSTDOCFLAGS="-Dwarnings" cargo doc --document-private-items --no-deps | ||
| RUSTDOCFLAGS="-Dwarnings -Zhigher-ranked-assumptions" cargo doc --document-private-items --no-deps |
Contributor
There was a problem hiding this comment.
Shall we by default to also set -Dwarnings in config.toml?
Contributor
Author
There was a problem hiding this comment.
I don't think this is a good idea. -Dwarnings is used here because we want to quickly detect the warning and return with error in CI, but not a general requirement when we build the doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add an experimental rustc flag
"-Zhigher-ranked-assumptions"to bypass the false positive borrow checker error discussed in rust-lang/rust#100013. The rustc flag is recently enabled after rust-lang/rust#143545 gets merged to the rust toolchain.After enabling this rustc flag, for the
on_key_valueandneareststate store trait method, which pass a closure to observe the slice value, the closure does not have to be static, and in the method caller, we can avoid unnecessary clone to make the closure static.Checklist
Documentation
Release note