refactor: remove some deps on lru - #23489
Merged
Merged
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to remove dependencies on the lru crate by replacing LRU cache implementations with simpler alternatives. The main change is replacing an LRU cache-based SetStmts implementation with an IndexMap-based solution, and consolidating indexmap dependency versions across the workspace.
Key changes:
- Replaced
LruCachewithIndexMapin the simulation test client'sSetStmtsstruct - Removed the
lrudependency from production code crates (stream,common) - Standardized
indexmapdependency version across workspace crates
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/simulation/src/client.rs | Replaced LruCache with IndexMap for storing SET statements, simplified iterator implementation |
| src/tests/simulation/Cargo.toml | Replaced lru dependency with indexmap |
| src/stream/src/executor/temporal_join.rs | Updated hasher import from lru::DefaultHasher to risingwave_common::lru::RandomState |
| src/stream/Cargo.toml | Removed lru dependency from stream crate |
| src/meta/Cargo.toml | Updated indexmap to use workspace version |
| src/connector/Cargo.toml | Updated indexmap to use workspace version |
| src/common/Cargo.toml | Moved lru dependency from main dependencies to dev-dependencies |
| Cargo.toml | Defined indexmap workspace dependency with version 2 and serde feature |
yezizp2012
approved these changes
Oct 16, 2025
wenym1
approved these changes
Oct 16, 2025
BugenZhao
force-pushed
the
bz/sorry-tick
branch
from
October 17, 2025 07:27
3ffa483 to
74a8ba6
Compare
BugenZhao
enabled auto-merge
October 17, 2025 07:28
BugenZhao
force-pushed
the
bz/sorry-tick
branch
from
October 21, 2025 05:59
74a8ba6 to
2a2978b
Compare
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/sorry-tick
branch
from
October 22, 2025 02:16
2a2978b to
7cb92fb
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 22, 2025
lrulru
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Checklist
Documentation
Release note