KFLUXINFRA-4426 render-diff: skip empty-base overlays

[oswcab]

instead of reporting BUILD ERROR

Components that use empty-base overlays (resources: []) to provide a valid no-op ArgoCD Application for non-targeted clusters produce no kustomize output. render-diff was treating this as "does not exist on either ref" and reporting a BUILD ERROR, which creates noise in PR reviews.

Now when a directory exists on at least one ref but kustomize produces no output, the component is silently skipped instead of reported as an error.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[github-actions]

Kustomize Render Diff

Comparing 66d24b333 → 367b8a941

No render differences detected.

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 6:39 PM UTC · Completed 6:52 PM UTC

Commit: e9d02ea · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.16

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.49%. Comparing base (66d24b3) to head (481a1eb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13840      +/-   ##
==========================================
+ Coverage   60.38%   60.49%   +0.10%     
==========================================
  Files          24       24              
  Lines        1628     1630       +2     
==========================================
+ Hits          983      986       +3     
  Misses        563      563              
+ Partials       82       81       -1     

Flag	Coverage Δ
go	60.49% <100.00%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fullsend-ai-review]

Risk Assessment: low (1/5)

Details

Small Go tooling change (2 files, 31 lines) with 50% test coverage ratio in stable code untouched for 175 days, no protected or security-sensitive paths, minimal risk.

Previous run

Risk Assessment: low (1/5)

Details

Small Go tooling change (2 files, 31 lines) with 50% test coverage ratio in stable code untouched for 175 days, no protected or security-sensitive paths, minimal risk.

[fullsend-ai-review]

Review

Findings

Low

• [test adequacy] infra-tools/internal/renderdiff/engine_test.go — The new test TestEngine_EmptyBase_NewComponent covers the case where the directory exists on HEAD but not on base and produces nil output. However, there is no corresponding test for the symmetric case where the directory exists on base but not on HEAD (removed component that had empty output), nor for the case where the directory exists on both refs but both produce nil output. These are valid scenarios exercised by the new DirExists guard in buildPair.
  Remediation: Consider adding tests for the symmetric cases: (1) base exists with nil output, head does not exist; (2) both exist with nil output.

---

Next steps:

• /fs-fix — agent addresses review findings automatically
• /fs-fix <your instruction> — agent fixes with your specific guidance
• Push commits directly — review re-runs automatically on push
• /fs-fix-stop — disable automatic fix runs for this PR

Previous run

Looks good to me

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 7:37 PM UTC · Completed 7:53 PM UTC

Commit: 66d24b3 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.96

[fullsend-ai-review]

See the review comment for full details.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oswcab, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [oswcab,sadlerap]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment