chore(deps): update module github.com/casbin/casbin/v2 to v3 - #159
chore(deps): update module github.com/casbin/casbin/v2 to v3#159red-hat-konflux[bot] wants to merge 1 commit into
Conversation
22b39d1 to
ff468fa
Compare
b3febfb to
703c60a
Compare
703c60a to
a72dfee
Compare
a72dfee to
b127e27
Compare
|
🤖 Finished Review · ✅ Success · Started 10:46 PM UTC · Completed 10:56 PM UTC |
ReviewFindingsCritical
Medium
Low
|
| github.com/bombsimon/logrusr/v2 v2.0.1 // indirect | ||
| github.com/bradleyfalzon/ghinstallation/v2 v2.17.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.135.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.102.0 // indirect |
There was a problem hiding this comment.
[critical] logic-error
The PR title claims to update casbin/casbin/v2 to v3, but the actual diff downgrades casbin/casbin/v2 from v2.135.0 to v2.102.0 (33 minor versions backward). The module path remains github.com/casbin/casbin/v2 with no migration to a v3 module path. This PR neither accomplishes its stated goal nor produces a safe change. This appears to be a Renovate bot misconfiguration.
Suggested fix: Reject this PR. Either properly migrate to casbin/casbin/v3 by changing the module path, or keep the existing v2.135.0 since casbin is an indirect dependency managed by ArgoCD's requirements.
| github.com/bombsimon/logrusr/v2 v2.0.1 // indirect | ||
| github.com/bradleyfalzon/ghinstallation/v2 v2.17.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.135.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.102.0 // indirect |
There was a problem hiding this comment.
[medium] missing-authorization
No linked issue exists to authorize this dependency change. Downgrading a transitive dependency by 33 minor versions warrants explicit rationale documenting why the downgrade is needed.
| github.com/casbin/casbin/v2 v2.135.0/go.mod h1:FmcfntdXLTcYXv/hxgNntcRPqAbwOG9xsism0yXT+18= | ||
| github.com/casbin/casbin/v2 v2.102.0 h1:weq9iSThUSL21SH3VrwoKa2DgRsaYMfjRNX/yOU3Foo= | ||
| github.com/casbin/casbin/v2 v2.102.0/go.mod h1:LO7YPez4dX3LgoTCqSQAleQDo0S0BeZBDxYnPUl95Ng= | ||
| github.com/casbin/govaluate v1.2.0/go.mod h1:G/UnbIjZk/0uMNaLwZZmFQrR72tYRZWQkO70si/iR7A= |
There was a problem hiding this comment.
[low] dependency-integrity
The go.sum file adds a new entry for github.com/casbin/govaluate v1.2.0/go.mod while retaining the existing v1.3.0 entry. This is standard Go module behavior but is a side effect of the questionable downgrade.
| github.com/bombsimon/logrusr/v2 v2.0.1 // indirect | ||
| github.com/bradleyfalzon/ghinstallation/v2 v2.17.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.135.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.102.0 // indirect |
There was a problem hiding this comment.
[low] transitive-dependency-risk
Casbin is a transitive dependency via argoproj/argo-cd/v2 v2.14.21 and is not directly imported by any Go source file. Go's MVS algorithm would override this pin if any dependency requires a higher version, making the manual pin potentially ineffective.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
b127e27 to
0cb22a0
Compare
This PR contains the following updates:
v2.135.0→v3.10.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
casbin/casbin (github.com/casbin/casbin/v2)
v3.10.0Compare Source
Features
v3.9.0Compare Source
Features
v3.8.2Compare Source
Bug Fixes
v3.8.1Compare Source
Bug Fixes
v3.8.0Compare Source
Features
v3.7.0Compare Source
Features
v3.6.0Compare Source
Bug Fixes
Features
v3.5.2Compare Source
Bug Fixes
v3.5.1Compare Source
Bug Fixes
v3.5.0Compare Source
Features
v3.4.2Compare Source
Bug Fixes
v3.4.1Compare Source
Bug Fixes
v3.4.0Compare Source
Features
v3.3.0Compare Source
Features
v3.2.0Compare Source
Features
v3.1.0Compare Source
Features
v3.0.1Compare Source
Bug Fixes
v3.0.0Compare Source
BREAKING CHANGES
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.