add controller modify secret to rbd sc#4018
Conversation
Adding controller modify secret to rbd sc which is required to modify the QoS or add new QoS for existing pvc. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
/assign @leelavg |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@leelavg am keeping this one hold, this can cause problem with provider/consumer where consumer is on OCP N-4, the sidecar will be very old and might cause problem due to these new parameters. we need to comeup with a plan to create SC with only know parameters specific to the sidecar, This is not really related to this feature but it can happen when new secrets are added to the SC. |
|
@Madhu-1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Adding controller modify secret to rbd sc which is required to modify the QoS or add new QoS for existing pvc.