Update to support Symfony 8 (PHP 8.4+)#1119
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Composer and internal-session integration updates so Ratchet can be installed with Symfony 8 (intended for PHP 8.4+) while keeping existing multi-version compatibility across older Symfony/PHP versions.
Changes:
- Widen
symfony/http-foundationandsymfony/routingconstraints to allow^8.0. - Update internal Symfony session storage/proxy documentation/comments to mention Symfony 8 compatibility.
- Keep the existing Symfony 7 compatibility layer as the selected implementation for Symfony 8 (no new compatibility classes introduced).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Ratchet/Session/Storage/VirtualSessionStorageForSymfony7.php |
Docblock updated to mention Symfony 8 usage. |
src/Ratchet/Session/Storage/VirtualSessionStorage.php |
Alias-selection comment updated to mention Symfony 8. |
src/Ratchet/Session/Storage/Proxy/VirtualProxyForSymfony7.php |
Docblock updated to mention Symfony 8 usage. |
src/Ratchet/Session/Storage/Proxy/VirtualProxy.php |
Alias-selection comment updated to mention Symfony 8. |
composer.json |
Allow symfony/http-foundation and symfony/routing ^8.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds support for Symfony 8 on PHP 8.4+. This is part 16 of reviving Ratchet as discussed in #1054, unblocking more future progress.
With these changes applied, the existing test suite now confirms that Symfony 8 can successfully be used on PHP 8.4+. Unlike the recent Symfony 6 (#1095) and Symfony 7 (#1098) updates which each needed dedicated compatibility classes, Symfony 8 requires none: its method signatures match Symfony 7's, so the existing classes already apply. This only widens the
symfony/http-foundationandsymfony/routingconstraints to allow^8.0. Thanks to Ratchet's multi-version constraints, Composer transparently picks up Symfony 8 on PHP 8.4+ while remaining compatible with legacy Symfony and PHP 5.4+ on older versions.Overall, reviving Ratchet remains a massive effort. If you want to support this project, please consider sponsoring @reactphp ❤️
Builds on top of #1118 and #1098, one step closer to reviving Ratchet as discussed in #1054