Skip to content

Imx662 fixes - #353

Open
davidplowman wants to merge 4 commits into
nextfrom
imx662-fixes
Open

Imx662 fixes#353
davidplowman wants to merge 4 commits into
nextfrom
imx662-fixes

Conversation

@davidplowman

Copy link
Copy Markdown
Collaborator

Fixes to make the IMX662 work better:

  • Correct frameIntegrationDiff prevents black levels going beserk.
  • Black levels can vary with analogue gain.
  • Correct black level vs. gain tuning added.
  • CT curve extended at the bottom end for less orange low light halogen images.

Comment thread src/ipa/rpi/cam_helper/cam_helper_imx290.cpp
IMX662 can still share its CamHelper with the IMX290 and other
sensors, but requires a frameIntegrationDiff of 6 (as opposed to 2 for
the others). The value 2 is invalid for the IMX662 and can lead to bad
black level values in HCG (High Conversion Gain) mode.

The CamHelperImx290 constructor is refactored slightly to allow the
IMX662 version to be created with a custom frameIntegrationDiff.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Optionally, a PWL (piecewise linear) function can be specified as the
black level instead of a constant value. This PWL is evaluated at the
current analogue gain for each frame.

Tuning files will also accept "black_level_func" as a shorthand for
all three channels.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
At very high gains, the measured black level increases noticeably
from the nominal value of 3200.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
The CT (colour temperature) curve is extended at the bottom end, so
that low lightl halogen images are less orange.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants