Skip to content

Remove deprecated setup_any_logging function #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
suhailnasar wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove deprecated setup_any_logging function #3788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions ignite/contrib/engines/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
from ignite.handlers.param_scheduler import ParamScheduler
from ignite.metrics import GpuInfo, RunningAverage
from ignite.metrics.metric import RunningBatchWise
from ignite.utils import deprecated



def setup_common_training_handlers(
Expand Down Expand Up @@ -287,21 +287,7 @@ def empty_cuda_cache(_: Engine) -> None:
gc.collect()


@deprecated(
"0.4.0",
"0.6.0",
("Please use instead: setup_tb_logging, setup_visdom_logging or setup_mlflow_logging etc.",),
raise_exception=True,
)
def setup_any_logging(
logger: BaseLogger,
logger_module: Any,
trainer: Engine,
optimizers: Optimizer | dict[str, Optimizer] | dict[None, Optimizer] | None,
evaluators: Engine | dict[str, Engine] | None,
log_every_iters: int,
) -> None:
pass



get_default_score_fn = Checkpoint.get_default_score_fn
Expand Down
6 changes: 1 addition & 5 deletions tests/ignite/contrib/handlers/test_logger_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import torch

import ignite.handlers as handlers
from ignite.contrib.engines.common import setup_any_logging

from ignite.engine import Engine, Events
from ignite.handlers.logger_utils import (
_setup_logging,
Expand Down Expand Up @@ -99,10 +99,6 @@ def set_eval_metric(engine):
return x_logger


def test_deprecated_setup_any_logging():
with pytest.raises(DeprecationWarning, match=r"deprecated since version 0.4.0"):
setup_any_logging(None, None, None, None, None, None)


def test__setup_logging_wrong_args():
with pytest.raises(TypeError, match=r"Argument optimizers should be either a single optimizer or"):
Expand Down