Skip to content

fix: detect ClassVar wrapped in ForwardRef on Python 3.14 #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muhamedfazalps wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: detect ClassVar wrapped in ForwardRef on Python 3.14 #1576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/attr/_make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,12 @@ def _is_class_var(annot):
annotations which would put attrs-based classes at a performance
disadvantage compared to plain old classes.
"""
annot = str(annot)
# Python 3.14+ wraps deferred annotations in ForwardRef.
# Extract the inner string to get the actual annotation text.
if hasattr(annot, "__forward_arg__"):
annot = annot.__forward_arg__
else:
annot = str(annot)

# Annotation can be quoted.
if annot.startswith(("'", '"')) and annot.endswith(("'", '"')):
Expand Down