ci(release): add a catch-all category to the release notes template - #409
Open
MateoLostanlen wants to merge 1 commit into
Open
ci(release): add a catch-all category to the release notes template#409MateoLostanlen wants to merge 1 commit into
MateoLostanlen wants to merge 1 commit into
Conversation
Unlabeled PRs matched no category, so GitHub dropped them and the generated notes came out empty.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
===========================================
+ Coverage 78.83% 79.11% +0.28%
===========================================
Files 6 6
Lines 841 838 -3
===========================================
Hits 663 663
+ Misses 178 175 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/release.ymldefined five label-based categories and no catch-all, so GitHub dropped every PR matching none of them. Since engine PRs carry no labels, the generated notes came out empty, as in v1.0.18.- title: Other changes/labels: ["*"]after the specific categories, which is what pyro-api does. Existing categories keep their precedence.develop.Checked with GitHub's own generator over the same range (
v1.0.17..HEAD): empty body with the config ondevelop, PRs listed under "Other changes" with the config on this branch.