Skip to content

fix(distribution): apply color and tooltip to custom status icons #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anehx merged 1 commit into from
Aug 12, 2026
Merged

fix(distribution): apply color and tooltip to custom status icons #3084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/-ember-caluma/app/components/custom-status-icon.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
✨
<span ...attributes>✨</span>
7 changes: 6 additions & 1 deletion packages/distribution/addon/components/cd-inquiry-status-icon.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{{#if @status.iconComponent}}
<@status.iconComponent @status={{@status}} @tooltipPos={{@tooltipPos}} />
<@status.iconComponent
@status={{@status}}
@tooltipPos={{@tooltipPos}}
class="uk-text-{{@status.color}}"
{{uk-tooltip @status.label pos=@tooltipPos}}
/>
{{else}}
<UkIcon
@icon={{@status.icon}}
Expand Down
10 changes: 9 additions & 1 deletion packages/distribution/tests/integration/components/cd-inquiry-status-icon-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module("Integration | Component | cd-inquiry-status-icon", function (hooks) {
// eslint-disable-next-line ember/no-empty-glimmer-component-classes
class CustomIconComponent extends Component {}
setComponentTemplate(
hbs`<span class="custom-icon">✨</span>`,
hbs`<span class="custom-icon" ...attributes>✨</span>`,
CustomIconComponent,
);

Expand All @@ -71,5 +71,13 @@ module("Integration | Component | cd-inquiry-status-icon", function (hooks) {

assert.dom("[uk-icon]").doesNotExist();
assert.dom(".custom-icon").hasText("✨");

// color and tooltip are applied via `...attributes` of the custom component
assert.dom(".custom-icon").hasClass("uk-text-success");
assert.tooltipHasText(this.element, ".custom-icon", "Custom!");
assert.deepEqual(
UIkit.tooltip(this.element.querySelector(".custom-icon")).pos,
["top", "center"], // UIkit adds "center" automatically
);
});
});
Loading