Upgrade master to Karamel master#298
Merged
tahina-pro merged 32 commits intoJul 3, 2026
Merged
Conversation
The karamel.done rule builds Karamel with `make -C opt/karamel`, whose krmllib sub-build reads `KRML_EXE ?= ../krml`. Since deps.Makefile exports KRML_EXE=opt/karamel/out/bin/krml (for EverParse's own build), that value leaked into the Karamel build and made krmllib depend on the not-yet-built out/bin/krml, failing with: make[2]: *** No rule to make target '.../karamel/out/bin/krml', needed by 'dist/generic/Makefile.include'. Stop. Unset KRML_EXE for the Karamel build so krmllib uses its freshly-built in-tree ../krml. Fixes `docker build --target deps .`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ing of Cygwin paths)
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades EverParse's
masterbranch to using Karamelmaster.In this process, this PR removes all uses of the
KRML_HOMEenvironment variable and relies onkrml -locate-krmllibandkrml -locate-includeinstead.Also, on Windows, EverParse compiles Karamel into
krml.exe, rather than having 3D copy the Karamel binary at every call.Part of the changes are replicated from
fstar2, which already uses Karamelmaster(or, at least, the Karamel packaged with F*, which is way more recent thaneverparse-fstar1)