Autofill Comma Correction for Visual Studio Code Extension#1525
Closed
John-Bobular wants to merge 1 commit into
Closed
Autofill Comma Correction for Visual Studio Code Extension#1525John-Bobular wants to merge 1 commit into
John-Bobular wants to merge 1 commit into
Conversation
Refactor insert text logic to handle commas and LSP tabstop identifiers.
Collaborator
|
Hi @John-Bobular and thanks for reporting and proposing a fix! I'm trying to reproduce the issue but it's not totally clear to me what the actual and expected behaviors are. Would you mind sharing the steps needed and what I should look at? Before/after screenshots might help. |
Collaborator
|
@John-Bobular @SableRaf yes would love steps to reproduce what you're describing. It will help me to review. I have a sense, but I need to be able to re-create (and understand) what you're fixing. thank you! |
Collaborator
|
just pinging again @John-Bobular. I will close this PR to keep things clean. if i end up closing it feel free to open up another PR or file an issue with details of what you're fixing so i can properly evaluate. thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current release version of the Processing Visual Studio Code extension, a comma is given for each argument that a method takes, rather than putting one comma. This means when auto filling a method call that has 2 arguments, 2 commas will be put inside the method parameters when only one would be needed to separate the two values.