Remove packed range macros and use a union instead#2326
Open
AZero13 wants to merge 1 commit into
Open
Conversation
Use a union instead.
mrgriffin
reviewed
Jun 20, 2026
mrgriffin
left a comment
mrgriffin
left a comment
Collaborator
There was a problem hiding this comment.
I'm open to being convinced that this is an improvement, but atm I'm not sure what the upside is, and the downside is needing to keep struct ObjectEventLinkPlayer in sync with struct ObjectEvent (which is an easy-to-miss trap and most projects extend graphicsId so it's not purely hypothetical).
AZero13
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.