add Makefile generation to make all - #193
Merged
Merged
Conversation
Collaborator
|
I also stumbed over this when working on #188. The makefiles used to be committed to the repo, and I think that’s why the documentation went out of date. They were removed by @lastland in 5300d89. General tip: Often the CI configuration is a better source for building instructions than the documentation, not just here :-) |
Collaborator
|
@quinn-dougherty Sorry for the late response---I'm traveling this week. This looks good and thanks for contributing the PR! I shall work on revising the document when I'm back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I struggled for a bit with
make allbecause theMakefiles weren't generated yet. I think future users would appreciate being able to just typemake allfrom the top level directory.The install procedure in queue tutorial neglects the generation of the per-directory
Makefiles.Happy to hear that it's not a best practice or something, just wanted to suggest something that I think would've lowered the friction on my end.