Skip to content

tests: Enlarge unittest timeout #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 2 commits into from
Jul 3, 2026
+19 −4
Merged

tests: Enlarge unittest timeout #10949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82e3850
tests: add runtime_ms for interrupted cases
JaySon-Huang Jul 2, 2026
ab5be73
tests: enlarge gtest timeout to 90min
JaySon-Huang Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions tests/gtest_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ def run(self):
try:
self.exit_code = sigint_handler.wait(task)
except sigint_handler.ProcessWasInterrupted:
self.runtime_ms = int(1000 * (time.time() - begin))
thread.exit()
self.runtime_ms = int(1000 * (time.time() - begin))
self.last_execution_time = None if self.exit_code else self.runtime_ms
Expand Down Expand Up @@ -366,13 +367,27 @@ def move_to(self, destination_dir, tasks):
def print_tests(self, message, tasks, print_try_number):
self.out.permanent_line("%s (%s/%s):" %
(message, len(tasks), self.total_tasks))
is_interrupted = message == 'INTERRUPTED TESTS'
for task in sorted(tasks):
try_number_suffix = (
(" (try #%d)" % task.execution_number) if print_try_number else "")
if is_interrupted:
if task.runtime_ms is not None:
self.out.permanent_line(
"Interrupted: %d ms: %s %s%s" % (
task.runtime_ms, task.test_binary, task.test_name,
try_number_suffix))
else:
self.out.permanent_line(
"Interrupted: %s %s%s" % (
task.test_binary, task.test_name, try_number_suffix))
continue

runtime_ms = 'Interrupted'
if task.runtime_ms is not None:
runtime_ms = '%d ms' % task.runtime_ms
self.out.permanent_line("%11s: %s %s%s" % (
runtime_ms, task.test_binary, task.test_name,
(" (try #%d)" % task.execution_number) if print_try_number else ""))
runtime_ms, task.test_binary, task.test_name, try_number_suffix))

def log_exit(self, task):
with self.stdout_lock:
Expand Down
4 changes: 2 additions & 2 deletions tests/run-gtest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ function run_test_parallel() {
args="--gtest_break_on_failure --gtest_catch_exceptions=0"
fi

# run with 60 min timeout
python ${SRC_TESTS_PATH}/gtest_parallel.py ${test_bins} --workers=${NPROC} ${args} --print_test_times --timeout=3600
# run with 90 min timeout
python ${SRC_TESTS_PATH}/gtest_parallel.py ${test_bins} --workers=${NPROC} ${args} --print_test_times --timeout=5400
}

set -e
Expand Down