forwarder: close goroutine leak when block in accept#1644
Conversation
✅ Deploy Preview for tidb-dashboard canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
+ Coverage 23.68% 24.17% +0.49%
==========================================
Files 177 173 -4
Lines 16055 15725 -330
==========================================
- Hits 3802 3801 -1
+ Misses 11968 11638 -330
- Partials 285 286 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Signed-off-by: husharp <jinhao.hu@pingcap.com>
|
@mornyx please help review , thanks~ |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@purelind: No presubmit jobs available for pingcap/tidb-dashboard@master DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@purelind: No presubmit jobs available for pingcap/tidb-dashboard@master DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
related tikv/pd#7782