Io\Poll\Context::wait() prevent integer overflow - #23468
Closed
marc-mabe wants to merge 1 commit into
Closed
Conversation
NickSdot
reviewed
Aug 26, 2026
Member
|
Hi @marc-mabe ; overflow check is safe_emalloc job here, so it s basically all about getting a tailored error message ?Not sure it s worth it honestly. Other unwarranted changes I see as well as variables declarations, we moved away from iso 90 a while ago. |
devnexen
reviewed
Aug 26, 2026
marc-mabe
force-pushed
the
poll_max_events
branch
2 times, most recently
from
August 26, 2026 20:39
52901ae to
ca8c209
Compare
marc-mabe
changed the title
devnexen
reviewed
Aug 26, 2026
marc-mabe
force-pushed
the
poll_max_events
branch
2 times, most recently
from
August 27, 2026 04:18
dd766cc to
317acb6
Compare
devnexen
reviewed
Aug 27, 2026
devnexen
reviewed
Aug 27, 2026
Member
|
once both nits are addressed, I would say it s lgtm |
marc-mabe
force-pushed
the
poll_max_events
branch
from
August 27, 2026 17:34
317acb6 to
17831b5
Compare
Contributor
Author
|
@devnexen changes are done as requested |
devnexen
approved these changes
Aug 27, 2026
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents integer overflow in case of
SIZEOF_INT < SIZEOF_ZEND_LONG