Skip to content

fix: derive CWD in duckdb-extensions common.sh so direct sourcing works - #75

Merged
vyruss merged 1 commit into
mainfrom
fix/current-working-directory-issue
Aug 8, 2026
Merged

fix: derive CWD in duckdb-extensions common.sh so direct sourcing works#75
vyruss merged 1 commit into
mainfrom
fix/current-working-directory-issue

Conversation

@maqeel75

@maqeel75 maqeel75 commented Aug 8, 2026

Copy link
Copy Markdown
Member

Summary

common.sh now derives CWD from its own BASH_SOURCE location when the caller hasn't set it.

@maqeel75
maqeel75 requested a review from vyruss as a code owner August 8, 2026 09:10
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6c294a4b-980f-44d1-b64d-89edb55c6224

📥 Commits

Reviewing files that changed from the base of the PR and between 32a7af7 and 3943b6b.

📒 Files selected for processing (1)
  • packaging/coldfront-duckdb-extensions/common.sh

📝 Walkthrough

Walkthrough

Changes

CWD initialization

Layer / File(s) Summary
Add CWD fallback initialization
packaging/coldfront-duckdb-extensions/common.sh
common.sh derives CWD from its own location when CWD is unset. Existing CWD values remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: vyruss

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: deriving CWD in common.sh to support direct sourcing.
Description check ✅ Passed The description accurately explains that common.sh derives CWD from BASH_SOURCE when the caller has not set it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/current-working-directory-issue

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@vyruss
vyruss merged commit f13b25e into main Aug 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants