feat(connect): support non-genesis-wasm execution device on mainnet spawn - #1313
Open
jim-toth wants to merge 1 commit into
Open
feat(connect): support non-genesis-wasm execution device on mainnet spawn#1313jim-toth wants to merge 1 commit into
jim-toth wants to merge 1 commit into
Conversation
…pawn Mainnet spawnWith hardcoded execution-device=genesis-wasm@1.0, so targeting another device (e.g. lua@5.3a) required a lowercase execution-device tag whose natural Execution-Device casing silently doubled the value and broke the process with device_not_loadable. It also stringified a map-valued module to "[object Object]". - resolve execution-device from EXECUTION_DEVICE env / args.executionDevice (default genesis-wasm@1.0; mirrors module/authority) - reject a non-string module instead of emitting "[object Object]" - document executionDevice on spawn; add node-free unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainnet
spawnWithhardcodedexecution-device=genesis-wasm@1.0, so targeting another device (e.g.lua@5.3a) required a lowercaseexecution-devicetag whose naturalExecution-Devicecasing silently doubled the value and broke the process withdevice_not_loadable. It also stringified a map-valued module to"[object Object]".EXECUTION_DEVICEenv/args.executionDevice(defaultgenesis-wasm@1.0; mirrors module/authority)"[object Object]"Closes #1312
Version Update
Select exactly one version update type. This choice is used by CI after the PR is merged into
mainto updateconnect/package.json, create the release tag, and publish the package to npm.