Migrate frontend deploy from bulletin-deploy to polkadot-app-deploy#49
Open
illegalcall wants to merge 1 commit into
Open
Migrate frontend deploy from bulletin-deploy to polkadot-app-deploy#49illegalcall wants to merge 1 commit into
illegalcall wants to merge 1 commit into
Conversation
4d4f479 to
4314749
Compare
4314749 to
763ddc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the retired
bulletin-deploywith its successorpolkadot-app-deploy(npm:@parity/polkadot-app-deploy) in the frontend deploy path, and updatesDEPLOY_DOC.mdstep 7 accordingly. Resolves the "Pending W3S environment support" caveat: the new tool ships the W3S/Summit environment.Notes for review
summit, notw3s. Verified against the published v0.10.0:--list-environmentsshowspaseo-next-v2andsummit;--env w3sfails withUnknown environment 'w3s'. CDM's own chain preset is still namedw3s(known_chains.ts), which is a separate namespace; the doc spells this out.--mnemonic(bare mnemonic) instead of--suri. A//Alice-style SURI no longer works; derivation goes through the tool's separate--derivation-path. The CI secret feedingCDM_DEPLOY_SURIis namedMNEMONIC, so this should be compatible, but worth confirming.BULLETIN_DEPLOY_ENV->APP_DEPLOY_ENV,SKIP_BULLETIN_INSTALL->SKIP_APP_DEPLOY_INSTALL. The only consumer (DEPLOY_DOC.md) is updated in this PR;.github/workflows/deploy-frontend.ymlnever set either, so it is unaffected.deploy-frontend.ymlruns this script on every push tomain, so the first post-merge push redeployscontracts.dot(onpaseo-next-v2) via the new tool. Recommend watching that run, or triggering it deliberately viaworkflow_dispatch. The runner has no IPFS Kubo; the tool falls back to pure-JS merkleization, but passing--js-merkleexplicitly in CI is cheap determinism if preferred.Verification
Ran the script end to end with the real frontend build and a PATH shim capturing the final invocation (to avoid publishing to the live
contracts.dot): argv is exactly--env summit --mnemonic <mnemonic> <dist> contracts.dotplus passthrough args. Installed the real npm package in a temp prefix to confirm the binary name, flags, and environments table. Probed: no-args usage (exit 1), default env withoutAPP_DEPLOY_ENV, and legacyBULLETIN_DEPLOY_ENVbeing ignored. Swept the repo for any remainingbulletin-deployreferences: none outside the two files changed here.