Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to capturing mic + all system audio. #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Default to capturing mic + all system audio. #39
Changes from all commits
e051859File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: I think
--no-micdoesn't actually disable the mic whenmic_deviceis set inconfig.toml:--no-micsetsconfig.audio.mic = False, butconfig.audio.mic_devicekeeps its value from the config file.CoreAudioRecorder.start()re-enables the mic from the device name alone (if self._mic or self._mic_device: cmd.append("--mic")).--mic --mic-device "USB Mic"and we record the mic anyway.Possible fix: clear
config.audio.mic_devicewhen--no-micis given, e.g.(same as CoPilot's comment below I just noticed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things on the tests here, non-blocking:
test_mic_flagrenamed, we no longer test that an explicit--micoverridesmic = falsefrom the config file. Maybe keep a--mictest next to the--no-micone?--mic-devicealone impliesmic = True— that implication now sits on its own line incli.pyand could regress silently.Once the
mic_deviceinteraction above is fixed, a test for config-setmic_device+--no-micwould be a nice-to-have too.Uh oh!
There was an error while loading. Please reload this page.