perf: rewrite field:* to _exists_:field - #502
Draft
dkharms wants to merge 1 commit into
Draft
Conversation
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can rewrite queries like
trace_id:*to_exists_:trace_idin regular search requests. The latter query is significantly lighter and significantly easier to compute because we have special_exists_index type.This way we do not need to build huge tree of iterators over all possible token values.
Back-of-the-envelope benchmarks:
If you have used LLM/AI assistance please provide model name and full prompt: