Skip to content

refactor: fair hit-rate for registry - #499

Open
dkharms wants to merge 1 commit into
0-scoped-cachefrom
0-scoped-cache-registry
Open

refactor: fair hit-rate for registry#499
dkharms wants to merge 1 commit into
0-scoped-cachefrom
0-scoped-cache-registry

Conversation

@dkharms

@dkharms dkharms commented Aug 18, 2026

Copy link
Copy Markdown
Member

Description

In this PR I've reintroduced fix for too high registry cache hit-rate.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

Stack created with GitHub Stacks CLIGive Feedback 💬

@dkharms
dkharms marked this pull request as ready for review August 18, 2026 14:48
@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.35878% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.25%. Comparing base (39a1693) to head (eff1f40).

Files with missing lines Patch % Lines
frac/sealed.go 54.34% 37 Missing and 5 partials ⚠️
frac/remote.go 84.61% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           0-scoped-cache     #499      +/-   ##
==================================================
+ Coverage           71.21%   71.25%   +0.04%     
==================================================
  Files                 234      234              
  Lines               19028    19007      -21     
==================================================
- Hits                13551    13544       -7     
+ Misses               4438     4434       -4     
+ Partials             1039     1029      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
MutexListAppend-4 a73114 8a760d
194.53 MB/s 175.31 MB/s 0.90 🔴
Sealing_WithSort-4 a73114 8a760d
40324408.00 B/op 73440320.00 B/op 1.82 🔴
5389.00 allocs/op 2005410.00 allocs/op 372.13 🔴

@dkharms
dkharms force-pushed the 0-scoped-cache-registry branch from db078cd to 150212c Compare August 18, 2026 16:16
@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Sealing_WithSort-4 a73114 70a023
40324408.00 B/op 72324136.00 B/op 1.79 🔴
5389.00 allocs/op 2005388.00 allocs/op 372.13 🔴

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
MutexListAppend-4 a73114 70a023
194.53 MB/s 173.44 MB/s 0.89 🔴
Sealing_WithSort-4 a73114 70a023
40324408.00 B/op 73440576.00 B/op 1.82 🔴
5389.00 allocs/op 2005411.00 allocs/op 372.13 🔴

@dkharms
dkharms force-pushed the 0-scoped-cache-registry branch from 150212c to eff1f40 Compare August 18, 2026 16:57
@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Indexer-4 a73114 a30b4b
678752766.00 B/op 764184994.00 B/op 1.13 🔴

@dkharms dkharms mentioned this pull request Aug 18, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants