Resume compilation of the clients generated by tests - #1421
Open
requiel20 wants to merge 1 commit into
Open
Conversation
`progenitor-impl/tests/output` exists so the checked-in output of the generator is compiled, not only compared as text. Nothing compiles it. The crate declares its own `[workspace]`, so a build from the repo root never reaches it, no CI job names the directory, and its `Cargo.lock` is gitignored, so no lock file recorded any drift. It has not built for a while. `cargo build` in that directory reports 1855 errors on current main. Most of them are because five of its dependencies fell behind the ones the workspace resolves, and since `progenitor-client` is a path dependency asking for reqwest 0.13 while this crate asked for 0.12, two versions of reqwest met in one tree. This PR bumps all those dependencies: | | was | now | | --- | --- | --- | | base64 | 0.21 | 0.23 | | httpmock | 0.7 | 0.8 | | rand | 0.8 | 0.10 | | regress | 0.7 | 0.12 | | reqwest | 0.12 | 0.13 | Another error comes from the generated buildomat CLI asking clap for a value parser it cannot infer. The crate now supplies it through `ValueParserFactory`. Finally, the crate must use rust 2021 as it emits the `gen` word in the code, which is reserved in Rust 2024. Two changes keep it from regressing again: - build the crate in CI - have dependabot watch the crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progenitor-impl/tests/outputexists so the checked-in output of the generator iscompiled, not only compared as text. Nothing compiles it. The crate declares its own
[workspace], so a build from the repo root never reaches it, no CI job names thedirectory, and its
Cargo.lockis gitignored, so no lock file recorded any drift.It has not built for a while.
cargo buildin that directory reports 1855 errors oncurrent main.
Most of them are because five of its dependencies fell behind the ones the workspace
resolves, and since
progenitor-clientis a path dependency asking for reqwest 0.13while this crate asked for 0.12, two versions of reqwest met in one tree. This PR
bumps all those dependencies:
Another error comes from the generated buildomat CLI asking clap for a value parser
it cannot infer. The crate now supplies it through
ValueParserFactory.Finally, the crate must use rust 2021 as it emits the
genword in the code, which isreserved in Rust 2024.
Two changes keep it from regressing again: