[VM metrics] add a metric for VMM VSZ#8071
Open
iximeow wants to merge 1 commit into
Open
Conversation
iximeow
marked this pull request as ready for review
April 30, 2025 19:40
iximeow
force-pushed
the
ixi/propolis-oximeter-vss
branch
from
May 1, 2025 17:26
3950a44 to
da5f770
Compare
iximeow
changed the title
iximeow
force-pushed
the
ixi/propolis-oximeter-vss
branch
2 times, most recently
from
May 8, 2025 20:35
b428c62 to
61b4a92
Compare
Member
Author
|
pay no mind to me applying b428c62 on the totally wrong branch... |
hawkw
approved these changes
May 15, 2025
| ] | ||
|
|
||
| [[metrics]] | ||
| name = "vmm_vsz" |
Member
There was a problem hiding this comment.
somewhat on the fence about this naming, since the oximeter metrics are functionally a public user interface; I might consider not abbreving vsz for clarity? but i might be wrong about that...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pairs with oxidecomputer/propolis#889. this would land first, then i'll plumb the schema change through to Propolis and remove the gross Cargo.toml patching that's in Propolis#889.