build(deps): bump koin from 3.3.3 to 4.2.2#4866
Conversation
29eafb9 to
f8964d6
Compare
f8964d6 to
4311401
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
Review — Koin 3.3.3 → 4.2.1 (major DI framework bump)
Reviewed as maintainer. This is a single-line version-catalog change, but it bumps the shared koin version ref that drives three artifacts (koin-core, koin-android, koin-androidx-workmanager) across a major version boundary (3.x → 4.x). Koin is the dependency-injection backbone here — org.koin.* is imported in 80+ source files — so a regression in the DI graph has app-wide blast radius (module definitions, KoinComponent injection, ViewModel/WorkManager scopes).
Blocking — CI is red. The Run Android Unit Tests check is failing on this PR (Detekt, instrumented data tests, validation all pass). A unit-test failure on a DI-framework major bump is exactly the signal that matters: it most likely reflects a compile/wiring break or a runtime DI-resolution change under Koin 4. This cannot be merged until that job is green and the failure root cause is understood (the expired logs should be re-run to capture it).
Koin 4 migration risks to verify before this can land (do not merge on a green-tests-alone basis without confirming these):
- API surface changes between 3.x and 4.x (e.g.
KoinPlatformTools, scope/KoinScopeComponentAPIs,koin-androidx-workmanagerwiring) — confirm no source still depends on removed/renamed 3.x symbols. - Min SDK / Kotlin / coroutines floors — Koin 4 raised its baselines; confirm this module's
minSdk, Kotlin (1.9.20 here), and coroutines versions satisfy Koin 4.2.x requirements. CoreResolverV2resolver rewrite (4.2.0): the 4.2.1 release notes explicitly call out that the new resolver regressed stacked-params lookup on linked scopes — specifically breakingAndroidParametersHolderstacked byKoinViewModelFactory+SavedStateHandleresolution from a child ViewModel scope (fixed in 4.2.1). Any ViewModel that injectsSavedStateHandlevia Koin must be smoke-tested at runtime, not just compiled.- DI graph correctness at runtime — green unit tests alone don't prove the full module graph resolves; a
checkModules/Koin verify test or a manual app-launch smoke test is warranted given the breadth of usage.
Verdict: changes-requested. Get Run Android Unit Tests green, identify the failure cause, and confirm the migration points above before re-review. Branch is also BEHIND main and needs a rebase. Holding off on approval/merge.
Automated maintainer review by Claude Code review agent.
|
@dependabot rebase |
Bumps `koin` from 3.3.3 to 4.2.2. Updates `io.insert-koin:koin-android` from 3.3.3 to 4.2.2 - [Release notes](https://github.com/InsertKoinIO/koin/releases) - [Commits](InsertKoinIO/koin@core-3.3.3...4.2.2) Updates `io.insert-koin:koin-androidx-workmanager` from 3.3.3 to 4.2.2 - [Release notes](https://github.com/InsertKoinIO/koin/releases) - [Commits](InsertKoinIO/koin@core-3.3.3...4.2.2) Updates `io.insert-koin:koin-core` from 3.3.3 to 4.2.2 - [Release notes](https://github.com/InsertKoinIO/koin/releases) - [Commits](InsertKoinIO/koin@core-3.3.3...4.2.2) --- updated-dependencies: - dependency-name: io.insert-koin:koin-android dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: io.insert-koin:koin-androidx-workmanager dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: io.insert-koin:koin-core dependency-version: 4.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
4311401 to
d4367b8
Compare
Bumps
koinfrom 3.3.3 to 4.2.2.Updates
io.insert-koin:koin-androidfrom 3.3.3 to 4.2.2Release notes
Sourced from io.insert-koin:koin-android's releases.
... (truncated)
Commits
dc86ef8Merge pull request #2448 from InsertKoinIO/release/4.2.2-finalize376ba1cFinalize 4.2.2: version 4.2.2 + nav3 typed entryProvider docs (#2336)0029f34Merge pull request #2446 from InsertKoinIO/fix/2348-env-properties-cast26020e8Fix #2348 - tolerate non-String environment properties (ClassCastException)fff5291Merge pull request #2432 from lfavreli-betclic/fix/2410-request-scope-atomic-id961521cMerge pull request #2444 from InsertKoinIO/fix/2299-vmscope-link-parent524eb25Fix #2299 - link viewModelScopeFactory scope to its parent scope8b99903Merge pull request #2443 from InsertKoinIO/docs/2417b-viewmodelscope-option7bb09d3Docs: viewModelScope { } requires viewModelScopeFactory() option (#2417)931132eMerge pull request #2442 from InsertKoinIO/fix/2426-tvos-viewmodel-targetsUpdates
io.insert-koin:koin-androidx-workmanagerfrom 3.3.3 to 4.2.2Release notes
Sourced from io.insert-koin:koin-androidx-workmanager's releases.
... (truncated)
Commits
dc86ef8Merge pull request #2448 from InsertKoinIO/release/4.2.2-finalize376ba1cFinalize 4.2.2: version 4.2.2 + nav3 typed entryProvider docs (#2336)0029f34Merge pull request #2446 from InsertKoinIO/fix/2348-env-properties-cast26020e8Fix #2348 - tolerate non-String environment properties (ClassCastException)fff5291Merge pull request #2432 from lfavreli-betclic/fix/2410-request-scope-atomic-id961521cMerge pull request #2444 from InsertKoinIO/fix/2299-vmscope-link-parent524eb25Fix #2299 - link viewModelScopeFactory scope to its parent scope8b99903Merge pull request #2443 from InsertKoinIO/docs/2417b-viewmodelscope-option7bb09d3Docs: viewModelScope { } requires viewModelScopeFactory() option (#2417)931132eMerge pull request #2442 from InsertKoinIO/fix/2426-tvos-viewmodel-targetsUpdates
io.insert-koin:koin-corefrom 3.3.3 to 4.2.2Release notes
Sourced from io.insert-koin:koin-core's releases.
... (truncated)
Commits
dc86ef8Merge pull request #2448 from InsertKoinIO/release/4.2.2-finalize376ba1cFinalize 4.2.2: version 4.2.2 + nav3 typed entryProvider docs (#2336)0029f34Merge pull request #2446 from InsertKoinIO/fix/2348-env-properties-cast26020e8Fix #2348 - tolerate non-String environment properties (ClassCastException)fff5291Merge pull request #2432 from lfavreli-betclic/fix/2410-request-scope-atomic-id961521cMerge pull request #2444 from InsertKoinIO/fix/2299-vmscope-link-parent524eb25Fix #2299 - link viewModelScopeFactory scope to its parent scope8b99903Merge pull request #2443 from InsertKoinIO/docs/2417b-viewmodelscope-option7bb09d3Docs: viewModelScope { } requires viewModelScopeFactory() option (#2417)931132eMerge pull request #2442 from InsertKoinIO/fix/2426-tvos-viewmodel-targets