Skip to content

fix(windows): pin Conan's CMake generator to match the project's #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fzipi wants to merge 2 commits into
base: v3/master
Choose a base branch
from
+10 −2
Open

fix(windows): pin Conan's CMake generator to match the project's #3605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab9a58
fix(windows): pin Conan's CMake generator to match the project's
fzipi Jul 28, 2026
936f608
refactor(windows): dedupe the VS generator string into one variable
fzipi Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ echo Build type: %build_type%
if not "%2"=="" (set arch=%2) else (set arch=x86_64)
echo Arch: %arch%

@rem Single source of truth for the targeted Visual Studio version: both the
@rem Conan-side generator pin below and the CMake -G flag must agree, or
@rem dependencies built from source (e.g. yajl, on --build=missing) can end
@rem up configured under a different VS/CMake than the main project.
set VS_GENERATOR=Visual Studio 17 2022

if "%3"=="USE_ASAN" (
echo Address Sanitizer: Enabled
set CI_ASAN=-c tools.build:cxxflags="[""/fsanitize=address""]"
Expand All @@ -20,9 +26,11 @@ if "%3"=="USE_ASAN" (
)

cd build\win32
conan install . -s compiler.cppstd=17 %CI_ASAN% --output-folder=build --build=missing --settings=build_type=%build_type% --settings=arch=%arch%
@rem Pin Conan's own generator for dependency builds (e.g. yajl, built from
@rem source on --build=missing) to VS_GENERATOR too -- see the note above.
conan install . -s compiler.cppstd=17 %CI_ASAN% -c tools.cmake.cmaketoolchain:generator="%VS_GENERATOR%" --output-folder=build --build=missing --settings=build_type=%build_type% --settings=arch=%arch%
cd build
cmake --fresh .. -G "Visual Studio 17 2022" -DCMAKE_TOOLCHAIN_FILE=conan_toolchain.cmake -DUSE_ASAN=%ASAN_FLAG% %4 %5 %6 %7 %8 %9
cmake --fresh .. -G "%VS_GENERATOR%" -DCMAKE_TOOLCHAIN_FILE=conan_toolchain.cmake -DUSE_ASAN=%ASAN_FLAG% %4 %5 %6 %7 %8 %9
cmake --build . --config %build_type%

popd
Loading