Skip to content

Scenario: guard TimeSync execution component against use after cleanup #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bltzr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Scenario: guard TimeSync execution component against use after cleanup #2113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f9d513
Scenario: guard TimeSync execution component against use after cleanup
bltzr Jul 13, 2026
99835c5
Scenario: sever model connections in TimeSync cleanup instead of guar…
bltzr Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/plugins/score-plugin-scenario/Scenario/Document/TimeSync/TimeSyncExecution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ TimeSyncComponent::TimeSyncComponent(
void TimeSyncComponent::cleanup(const std::shared_ptr<TimeSyncComponent>& self)
{
OSSIA_ENSURE_CURRENT_THREAD_KIND(ossia::thread_type::Ui);
// Destruction is deferred through the exec then gc queues while the model
// may stay alive and editable: sever the model connections so no edit can
// reach this component once m_ossia_node is reset.
if(m_score_node)
QObject::disconnect(m_score_node, nullptr, this, nullptr);
in_exec([self, ts = m_ossia_node, gcq_ptr = weak_gc] {
OSSIA_ENSURE_CURRENT_THREAD_KIND(ossia::thread_type::Audio);
ts->cleanup();
Expand Down
Loading